Omit zero srcPort / dstPort in Traceflow requests from web client #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with v1beta1 of the Traceflow API, it is invalid to explicitly set srcPort / dstPort to 0. 0 is not a valid port value in general, and the UI uses 0 for some special cases (e.g., to tell the server to use a random srcPort for a Traceflow request). Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea-ui
that referenced
this pull request
May 10, 2024
…trea-io#361) Starting with v1beta1 of the Traceflow API, it is invalid to explicitly set srcPort / dstPort to 0. 0 is not a valid port value in general, and the UI uses 0 for some special cases (e.g., to tell the server to use a random srcPort for a Traceflow request). Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
May 10, 2024
Starting with v1beta1 of the Traceflow API, it is invalid to explicitly set srcPort / dstPort to 0. 0 is not a valid port value in general, and the UI uses 0 for some special cases (e.g., to tell the server to use a random srcPort for a Traceflow request). Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with v1beta1 of the Traceflow API, it is invalid to explicitly set srcPort / dstPort to 0. 0 is not a valid port value in general, and the UI uses 0 for some special cases (e.g., to tell the server to use a random srcPort for a Traceflow request).