Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 3 Upgrade #48

Merged
merged 5 commits into from
Aug 4, 2015
Merged

Grails 3 Upgrade #48

merged 5 commits into from
Aug 4, 2015

Conversation

dmahapatro
Copy link
Contributor

  • Plugin was upgraded to Grails 3.
  • OAuth Scribe was updated to v1.3.7
  • Tests passing.
  • Sample app working.

Please merge PR.

Thanks
Dhiraj

@antony
Copy link
Owner

antony commented Jul 28, 2015

Very nice, thanks!

Will the plugin still work with Grails 2.x ?

Cheers,
Antony

@dmahapatro
Copy link
Contributor Author

@antony Nope. This will not work with Grails 2.x. This plugin upon publish creates a .jar artifact as compared to .zip artifact with Grails 2.x.

The minimal version of Grails app should be 3.0.0 (also mentioned in the plugin descriptor)

I have had upgraded docs accordingly. The last release before this PR is merged will be the latest available release for Grails 2.

@antony
Copy link
Owner

antony commented Jul 29, 2015

Ok great I will merge as soon as possible

antony added a commit that referenced this pull request Aug 4, 2015
@antony antony merged commit de87251 into antony:master Aug 4, 2015
@antony
Copy link
Owner

antony commented Aug 4, 2015

I can't release the plugin I'm afraid. This is the case for 4 or 5 of my plugins:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':publishMavenPublicationToMavenRepository'.
> Failed to publish publication 'maven' to repository 'maven'
   > java.lang.NullPointerException (no error message)

Not sure what to do about that error.

@dmahapatro
Copy link
Contributor Author

@antony You can publish the plugin to bintray after creating an account. Most of the Grails plugins are published is bintray now. Reference from audit logging plugin.

@antony
Copy link
Owner

antony commented Aug 4, 2015

Ok I didn't know that, haven't used grails for a few years now :)

Will do it asap

On Tue, 4 Aug 2015 18:11 Dhiraj Mahapatro [email protected] wrote:

@antony https://github.com/antony You can publish the plugin to bintray
after creating an account. Most of the Grails plugins are published is
bintray now. Reference from audit logging plugin
https://github.com/robertoschwald/grails-audit-logging-plugin/blob/master/audit-logging/build.gradle#L74
.


Reply to this email directly or view it on GitHub
#48 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants