Add password authentication request validation #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a password-based authentication mechanism under the option `--authentication-password-request-url`, which functions similarly to `--authentication-key-request-url`, but takes a password instead of a public key. Closes antoniomika#322
|
This seems to work on my sish instance, with a simple verification server that checks for a single password and returns 200. I've used a command like this one for testing (which then prompts me for the password): ssh -o PubkeyAuthentication=no -o PreferredAuthentications=password -R test:80:localhost:8080 tuns.shI haven't tested the timeout, however since this is basically a copy-pasted version of |
|
Thanks for the awesome contribution @EpicEric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a password-based authentication mechanism under the option
--authentication-password-request-url, which functions similarly to--authentication-key-request-url, but takes a password instead of a public key.Closes #322