Fix break on Windows caused by Node security fix. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey, @cliffAtOsaic, Should this option be applied for windows only? |
antongolub
approved these changes
Aug 6, 2024
|
Thanks for highlighting the issue and for the patch. Released as part of v10.0.8. Could you verify it? |
|
Upgraded to the latest and it is working now on my box. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #334.
The new code requires
{ shell: true }to be passed tochild_process.sync()andchild_process.spawnSync()in order to execute batch scripts. On Windows, npm and similar commands are run as "npm.cmd" rather than "npm.exe" and requires shell to be set to true.Also fixed a warning that TypeDocs was running against an incompatible version of TypeScript. Fix was to upgrade TypeDocs to the latest version.