Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit with non-zero if anything fails #11

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

qwelias
Copy link
Contributor

@qwelias qwelias commented Aug 6, 2020

  • if something fails CLI should not exit with 0 (older NodeJS versions do not fail on unhandled rejections autpmatically)
  • CLI does not need to export anything
  • CLI integration tests should be done in shell env, not in unit test env
  • homemade promisify thrown away as well as await of stage steps because because they all are synchronous, and promisify is actually misleading because there should be only one, plus TS will not allow dangling promises in case any of the steps returns a promise
  • asyncForEach thrown away because for await...of
  • invoke should inherit stdio to provide seamless output

throw away excessive code

refactor tests
@antongolub
Copy link
Owner

Hi @qwelias, CC @PatrykMilewski

I've added async flow to let invocations to subscribe on data event in favour of #10, but your proposal is even much better. Thanks a lot for the contribution.

We now have an extra call for build (as a part of travis.yml and test:integration), and a slight drop in coverage. So I'll fix this a bit later.

@antongolub antongolub merged commit 3e7eb93 into antongolub:master Aug 6, 2020
antongolub added a commit that referenced this pull request Aug 6, 2020
## [1.4.1](v1.4.0...v1.4.1) (2020-08-06)

### Bug Fixes

* exit with non-zero if anything fails ([#11](#11)) ([3e7eb93](3e7eb93)), closes [#10](#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants