Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: workspaces configuration is being removed if INT signal was sent in the middle #6

Closed
PatrykMilewski opened this issue Jul 31, 2020 · 4 comments · Fixed by #8
Closed

Bug: workspaces configuration is being removed if INT signal was sent in the middle #6

PatrykMilewski opened this issue Jul 31, 2020 · 4 comments · Fixed by #8
Assignees
@antongolub
Labels
enhancement New feature or request released

Comments

@PatrykMilewski
Copy link

Hello!

After running yarn-audit-fix, my configuration of Yarn Workspaces from package.json file is removed, if I send INT signal, when yarn-audit-fix is still working.

I believe it's due to creating a copy of package.json (origin.package.json) which overwrites package.json file and removes workspaces configuration.
I believe it would be safer to never overwrite package.json file, since process of fixing audit takes some time and it's very common to interrupt it in the middle of it.

I'm using 1.3.0 version.
@antongolub
Copy link
Owner

@PatrykMilewski
Hi.

I agree, it's a bit annoying. I thought about moving all interactions to some temp directory, but this also requires node_modules to be copied due to npm audit fix. I'll try to work around this with a symlink.

@antongolub
Copy link
Owner

@PatrykMilewski

Do you want a test drive? [email protected]

antongolub added a commit that referenced this issue Jul 31, 2020
@antongolub
feat: perform most operations on temporary entities
63c4696 
closes #6
@antongolub antongolub mentioned this issue Jul 31, 2020
Merged
@antongolub antongolub self-assigned this Aug 1, 2020
@antongolub antongolub added the enhancement New feature or request label Aug 1, 2020
@PatrykMilewski
Copy link
Author

@antongolub Works great! Just tested it! Thank you

antongolub added a commit that referenced this issue Aug 3, 2020
@antongolub
feat: perform most operations on temporary entities
213b4f5 
closes #6
antongolub added a commit that referenced this issue Aug 3, 2020
@antongolub
chore(release): 1.4.0 [skip ci]
20eb4ec 
# [1.4.0](v1.3.0...v1.4.0) (2020-08-03)

### Features

* add async handlers support ([71eab4e](71eab4e))
* perform most operations on temporary entities ([213b4f5](213b4f5)), closes [#6](#6)
@antongolub
Copy link
Owner

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antongolub antongolub

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: perform most operations on temporary entities antongolub/yarn-audit-fix
2 participants
@antongolub @PatrykMilewski