Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary dowgrading __metadata version from 6 to 5 during run #287

Closed
ssbarnea opened this issue Mar 21, 2023 · 2 comments · Fixed by #288
Closed

Temporary dowgrading __metadata version from 6 to 5 during run #287

ssbarnea opened this issue Mar 21, 2023 · 2 comments · Fixed by #288
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link

I observed that that when using yarn-audit-fix as a pre-commit hook it does temporary downgrades the metadata version from my current 6 to 5 but it does put it back after.

__metadata:
  version: 5

This is still a bug as the file should not be modified during run if that is not needed.
antongolub added a commit that referenced this issue Mar 21, 2023
@antongolub
fix: do no mutate __metadata
8af1e08 
closes #287
@antongolub antongolub added the bug Something isn't working label Mar 21, 2023
@antongolub
Copy link
Owner

@ssbarnea,

Well, I agree, __metadata mutation seems redundant.

@antongolub antongolub mentioned this issue Mar 21, 2023
Merged
antongolub added a commit that referenced this issue Mar 21, 2023
@antongolub
fix: do no mutate __metadata
97c5706 
closes #287
antongolub added a commit that referenced this issue Mar 21, 2023
@antongolub
chore(release): 9.3.10 [skip ci]
7a92805 
## [9.3.10](v9.3.9...v9.3.10) (2023-03-21)

### Bug Fixes

* do no mutate __metadata ([97c5706](97c5706)), closes [#287](#287)
@ssbarnea
Copy link
Author

@antongolub Thanks! That was blazing fast reaction! Added a bit of sunshine to what was looking like boring working day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do no mutate __metadata antongolub/yarn-audit-fix
2 participants
@ssbarnea @antongolub