chore: minor code imprs

antongolub · Oct 26, 2024 · 832cda3 · 832cda3
1 parent 6d6499e
commit 832cda3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/src/main/ts/cli.ts b/src/main/ts/cli.ts
@@ -14,8 +14,7 @@ const parseMultipleValueArg = (
     return value
   }
 
-  const previousArray = Array.isArray(previous) ? previous : [previous]
-  return previousArray.concat([value])
+  return [previous, value].flat()
 }
 
 const env = process.env

diff --git a/src/main/ts/util.ts b/src/main/ts/util.ts
@@ -71,16 +71,15 @@ export const formatFlags = (flags: TFlags, ...picklist: string[]): string[] =>
     const flag = formatFlag(key)
 
     if (checkValue(key, value, omitlist, picklist)) {
-      if (!Array.isArray(value)) {
+      if (Array.isArray(value)) {
+        value.forEach((val) => {
+          memo.push(flag, String(val))
+        })
+      } else {
         memo.push(flag)
-
         if (value !== true) {
           memo.push(String(value))
         }
-      } else {
-        value.forEach((val) => {
-          memo.push(flag, String(val))
-        })
       }
     }
 

diff --git a/src/test/ts/util.ts b/src/test/ts/util.ts
@@ -91,7 +91,7 @@ describe('util', () => {
         ],
         [{ exclude: [] }, ['exclude'], []],
         [
-          { exclude: ['@scope/package'] },
+          { exclude: ['@scope/package'] }, // eslint-disable-line sonarjs/no-duplicate-string
           ['exclude'],
           ['--exclude', '@scope/package'],
         ],