Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colored timestamp option #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

malaow3
Copy link

@malaow3 malaow3 commented Jun 9, 2022

Add a struct field option to allow for log-level colored timestamps

@dfateyev
Copy link
Contributor

dfateyev commented Jun 9, 2022

  1. The changes proposed don't respect "NoColors" option
  2. Lacks of test (optional?)
  3. Not sure whether we need timestamp colorization, at all

@malaow3
Copy link
Author

malaow3 commented Jun 9, 2022

Forgot about the NoColors option -- can make that change. Not sure how / what tests would need to be added for this change. Also don't think this is needed by any means - just more of a "nice to have" for a probably very niche subset of users. If this is a change that could be adopted, I can go ahead and fix the NoColors issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants