clarify wording that variables should be used for code that could be … #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by others, but its not required that you varibalise config in the code that uses modules
|
Thanks for the proposal, but the addition is too specific to be included (as we discussed in twitter). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…used by others, but its not required that you varibalise config in the code that uses modules.
This line can be interpreted as "even the calling TF should have everything as variable", despite them never changing, adding un-required layers of abstraction.
https://gist.github.com/cuotos/0ac1d8aee3309e3921d21dbd9699cbb3