Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WSL): Make parallelism work appropriately #728

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

yermulnik
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Fixes #727

@yermulnik yermulnik force-pushed the fix/detect_wsl_as_not_k8s branch from de3feef to 040b977 Compare October 30, 2024 20:56
@MaxymVlasov MaxymVlasov changed the title fix(common::get_cpu_num): Do not identify WSL as K8S fix(WSL): Make parallelism work appropriately Oct 31, 2024
Copy link
Collaborator

@MaxymVlasov MaxymVlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for confirmation from reporter that it works for him, and then it ready to merge

@MaxymVlasov MaxymVlasov added bug Something isn't working area/windows labels Oct 31, 2024
@yermulnik yermulnik merged commit e87ee43 into master Oct 31, 2024
6 checks passed
@yermulnik yermulnik deleted the fix/detect_wsl_as_not_k8s branch October 31, 2024 19:31
antonbabenko pushed a commit that referenced this pull request Oct 31, 2024
## [1.96.2](v1.96.1...v1.96.2) (2024-10-31)

### Bug Fixes

* **WSL:** Make parallelism work appropriately ([#728](#728)) ([e87ee43](e87ee43))
@antonbabenko
Copy link
Owner

This PR is included in version 1.96.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script _common.sh fails to detect correct CPU count in WSL (Windows Subsystem for Linux) distro
3 participants