Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace mapfile to support Bash 3.2.57 pre-installed in macOS #627

Merged
merged 8 commits into from
Feb 19, 2024
Merged

fix: Replace mapfile to support Bash 3.2.57 pre-installed in macOS #627

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5deea8c
[`hooks/_common.sh`] Replace `mapfile` to support older Bash
yermulnik Feb 19, 2024
bf354a2
Declare `dir_paths_unique` as local and as array
yermulnik Feb 19, 2024
a272c33
Address PR discussion by creating array in a one-liner
yermulnik Feb 19, 2024
310cf28
Apply suggestions from code review
MaxymVlasov Feb 19, 2024
2f9dfe9
Apply suggestions from code review
MaxymVlasov Feb 19, 2024
ebd7079
pre-commit fixes
Feb 19, 2024
24ac3cf
Address remark about array elements splitting
yermulnik Feb 19, 2024
2e14c16
Resolve merge conflict
yermulnik Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hooks/_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,9 @@ function common::per_dir_hook {

local pids=()

mapfile -t dir_paths_unique < <(echo "${dir_paths[@]}" | tr ' ' '\n' | sort -u)
# shellcheck disable=SC2207
MaxymVlasov marked this conversation as resolved.
Show resolved Hide resolved
local -a dir_paths_unique=( $(printf '%s\n' "${dir_paths[@]}" | sort -u) )
yermulnik marked this conversation as resolved.
Show resolved Hide resolved

local length=${#dir_paths_unique[@]}
local last_index=$((${#dir_paths_unique[@]} - 1))

Expand Down
Loading