Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with "no logs shown" when somthing goes wrong #624

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix issue with "no logs shown" when somthing goes wrong #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions hooks/_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ function common::per_dir_hook {
done

CPU=$(common::get_cpu_num "$parallelism_cpu_cores")

# parallelism_limit can include reference to 'CPU' variable
parallelism_limit=$((parallelism_limit))
local parallelism_disabled=false
Expand All @@ -324,13 +323,17 @@ function common::per_dir_hook {
parallelism_limit=1
parallelism_disabled=true
fi

local final_exit_code=0
local pids=()

mapfile -t dir_paths_unique < <(echo "${dir_paths[@]}" | tr ' ' '\n' | sort -u)
local length=${#dir_paths_unique[@]}
local last_index=$((${#dir_paths_unique[@]} - 1))

local final_exit_code=0
# preserve errexit status
shopt -qo errexit && ERREXIT_IS_SET=true
# allow hook to continue if exit_code is greater than 0
set +e
# run hook for each path in parallel
for ((i = 0; i < length; i++)); do
dir_path="${dir_paths_unique[$i]//__REPLACED__SPACE__/ }"
Expand Down Expand Up @@ -362,6 +365,8 @@ function common::per_dir_hook {

done

# restore errexit if it was set before the "for" loop
[[ $ERREXIT_IS_SET ]] && set -e
# return the hook final exit_code
exit $final_exit_code
}
Expand Down
Loading