fix: Speed up x2 TFLint hook execution in dirs with violations #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexton
changed the title
MaxymVlasov
approved these changes
Apr 28, 2023
MaxymVlasov
changed the title
yermulnik
reviewed
Apr 28, 2023
4 tasks
MaxymVlasov
reviewed
Apr 28, 2023
yermulnik
approved these changes
Apr 28, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Apr 28, 2023
## [1.77.4](v1.77.3...v1.77.4) (2023-04-28) ### Bug Fixes * Speed up x2 TFLint hook execution in dirs with violations ([#514](#514)) ([49974ab](49974ab))
|
This PR is included in version 1.77.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
Caches the output of the TFLint commands - upon failures the existing behavior was to re-run to present the output. This should speed up performance where there are lots of scattered failures in many directories.
How can we test changes
I have tested locally with a single failing repo - showed a 48% reduction in wall clock time with the
try-repohooks.Substantial speedup in a monorepo with scattered failures across many directories.