Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rewrite terraform_validate to common::per_dir_hook #404

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

MaxymVlasov
Copy link
Collaborator

That's one of many PRs to the pre-release branch, each one will depend on the previous one.
That is the way to include all that info in one release...

Also, close #402.

@MaxymVlasov MaxymVlasov requested a review from yermulnik as a code owner July 4, 2022 17:35
Copy link
Collaborator Author

@MaxymVlasov MaxymVlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some notes about future improvements, to avoid extra attention to them in this PR

hooks/terraform_validate.sh Show resolved Hide resolved
hooks/terraform_validate.sh Show resolved Hide resolved
hooks/terraform_validate.sh Show resolved Hide resolved
hooks/terraform_validate.sh Show resolved Hide resolved
@MaxymVlasov MaxymVlasov force-pushed the refactor/terraform_validate branch from 00926cc to eea6c00 Compare July 4, 2022 18:07
@MaxymVlasov MaxymVlasov merged commit b033d65 into pre-release Jul 4, 2022
@MaxymVlasov MaxymVlasov deleted the refactor/terraform_validate branch July 4, 2022 18:09
antonbabenko pushed a commit that referenced this pull request Jul 12, 2022
* Refactor: Rewrite `terraform_validate` to `common::per_dir_hook`
* Add ability to specify `--hook-config` in future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants