Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pre-commit-terraform terraform_validate hook #401

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix: Pre-commit-terraform terraform_validate hook #401

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef788b0
Fix hooks/terraform_validate.sh
nshenry03 Jun 17, 2022
4f5ce3b
Update hooks/terraform_validate.sh
nshenry03 Jun 21, 2022
6e667fa
Update hooks/terraform_validate.sh
nshenry03 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/terraform_validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function terraform_validate_ {

if [[ -n "$(find "$dir_path" -maxdepth 1 -name '*.tf' -print -quit)" ]]; then

pushd "$(cd "$dir_path" && pwd -P)" > /dev/null
pushd "$(cd "$dir_path" > /dev/null && pwd -P)" > /dev/null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, you found code written in Paleolithic.

Let's try reuse logic that used in common functions here:

https://github.com/antonbabenko/pre-commit-terraform/blob/master/hooks/_common.sh#L178

Absolutely have no idea why it was written in so complex way


if [ ! -d .terraform ]; then
set +e
Expand Down