Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Infracost links #396

Merged
merged 1 commit into from
Jun 9, 2022
Merged

docs: Fix Infracost links #396

merged 1 commit into from
Jun 9, 2022

Conversation

alikhajeh1
Copy link
Contributor

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

None of the above.

Description of your changes

This PR fixes old Infracost links and mentions the behavior of the latest CLI version (which parses HCL by default).

@alikhajeh1 alikhajeh1 changed the title docs: fix Infracost links Fix Infracost links Jun 9, 2022
@alikhajeh1 alikhajeh1 changed the title Fix Infracost links docs: Fix Infracost links Jun 9, 2022
yermulnik
yermulnik approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antonbabenko
antonbabenko approved these changes Jun 9, 2022
View reviewed changes
Copy link
Owner

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, someone with proper English skills! Thank you, Ali! 👍

@antonbabenko antonbabenko merged commit 598bf2c into antonbabenko:master Jun 9, 2022
@alikhajeh1 alikhajeh1 deleted the patch-1 branch June 9, 2022 23:12
@MaxymVlasov MaxymVlasov added documentation Improvements or additions to documentation hook/infracost_breakdown Bash hook labels Jun 10, 2022
@antonbabenko
Copy link
Owner

This PR is included in version 1.72.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

@yermulnik yermulnik yermulnik approved these changes

@MaxymVlasov MaxymVlasov Awaiting requested review from MaxymVlasov MaxymVlasov is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hook/infracost_breakdown Bash hook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alikhajeh1 @antonbabenko @yermulnik @MaxymVlasov