Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for pre-commit/pre-commit-hooks in Docker image #374

Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat: Add support for pre-commit/pre-commit-hooks in Docker image #374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7086b8d
feat: Add alpine-sdk as package to be able to run third party hooks
Jno21 Apr 21, 2022
54f0169
fix: Add musl-dev and gcc to be able to run pre-commit-hooks
Jno21 Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ RUN apk add --no-cache \
# pre-commit deps
git=~2 \
# All hooks deps
bash=~5
bash=~5 \
alpine-sdk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be added to this line to align with how other packages in this block are described?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean, do you mean should we add another comment to differentiate the hooks deps.

Suggested change
alpine-sdk
# Third party hooks deps
alpine-sdk

Like this ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's what I mean. Thanks.


# Copy tools
COPY --from=builder \
Expand Down