Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should show the file path when something is changed or goes wrong #54

Open
robsonpeixoto opened this issue Jul 4, 2019 · 5 comments
Open

It should show the file path when something is changed or goes wrong #54

robsonpeixoto opened this issue Jul 4, 2019 · 5 comments
Labels
estimate/1day Need 1 work day to be done feature New feature or request hook/terraform_checkov Bash hook hook/terraform_docs_replace Python hook hook/terraform_docs Bash hook hook/terraform_fmt Bash hook hook/terraform_providers_lock Bash hook hook/terraform_tflint Bash hook hook/terraform_validate Bash hook hook/terragrunt_validate Bash hook hook/terrascan Bash hook
Milestone
Features implemen...

Comments

@robsonpeixoto
Copy link
Contributor

When something get wrong, it doesn't show the file path and it is very useful.

❯ git commit -v
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /Users/robinho/.cache/pre-commit/patch1562252730.
Terraform fmt............................................................Failed
hookid: terraform_fmt

Files were modified by this hook. Additional output:

cluster.tf

Error: Invalid block definition

  on vars.tf line 20:
  (source code not available)

A block definition must have block content delimited by "{" and "}", starting
on the same line as the block header.
@robsonpeixoto robsonpeixoto changed the title It should show the file path It should show the file path when something is changed or get wrong Jul 4, 2019
@robsonpeixoto robsonpeixoto changed the title It should show the file path when something is changed or get wrong It should show the file path when something is changed or goes wrong Jul 4, 2019
@varac
Copy link

varac commented Dec 2, 2020

Oh just noticed I created a duplicate of this (#161) and a PR to fix it (#162)

@MaxymVlasov MaxymVlasov added estimate/1h Need 1 hour to be done hook/terraform_docs Bash hook feature New feature or request labels Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2021
@antonbabenko
Copy link
Owner

@MaxymVlasov Let's make sure that the path is also shown for all other hooks we have (including tflint, tfsec, fmt).

@antonbabenko antonbabenko removed the stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2021
@MaxymVlasov MaxymVlasov added the hook/terrascan Bash hook label Nov 3, 2021
@david-heward-unmind
Copy link

Did you get anywhere with this? Appreciate the world is pretty F'd up right now. No rush at all.

It's pretty irritating getting messages like this though.

Terragrunt validate......................................................Failed
- hook id: terragrunt_validate
- files were modified by this hook

@MaxymVlasov MaxymVlasov mentioned this issue Apr 7, 2022
Closed
@thomaslast thomaslast mentioned this issue Apr 7, 2022
Closed
4 tasks
@albertorm95
Copy link

@MaxymVlasov Let's make sure that the path is also shown for all other hooks we have (including tflint, tfsec, fmt).

Any update on this?

@MaxymVlasov MaxymVlasov reopened this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate/1day Need 1 work day to be done feature New feature or request hook/terraform_checkov Bash hook hook/terraform_docs_replace Python hook hook/terraform_docs Bash hook hook/terraform_fmt Bash hook hook/terraform_providers_lock Bash hook hook/terraform_tflint Bash hook hook/terraform_validate Bash hook hook/terragrunt_validate Bash hook hook/terrascan Bash hook
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

No branches or pull requests
6 participants
@robsonpeixoto @antonbabenko @varac @albertorm95 @MaxymVlasov @david-heward-unmind