Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFlint doesn't show full path when we hit an error #356

Closed
thomaslast opened this issue Apr 6, 2022 · 1 comment
Closed

TFlint doesn't show full path when we hit an error #356

thomaslast opened this issue Apr 6, 2022 · 1 comment
Labels
area/docker bug Something isn't working

Comments

@thomaslast
Copy link

thomaslast commented Apr 6, 2022

Describe the bug

Currently when we run the pre-commit for tflint we get errors but only with the filename. In a structure that re-uses the same name in different folders this isn't enough to distinguish between files. It should report the full path on an error.

How can we reproduce it?

pre-commit run --all-files

Error: Unsupported argument

  on main.tf line 32:
  32:   region     = "eu-west-1"

Environment information

  • OS:

OS: Ubuntu 20.04

  • docker info:
v1.51.0
  • .pre-commit-config.yaml:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.51.0
  hooks:
    - id: terraform_fmt
    - id: terraform_tflint
      args:
        - --args=--config=__GIT_WORKING_DIR__/img/precommit/.tflint.hcl
        - --args=--enable-rule=terraform_documented_variables
        - --args=--enable-rule=terraform_deprecated_index
        - --args=--enable-rule=terraform_unused_required_providers
        - --args=--enable-rule=terraform_standard_module_structure
        - --args=--enable-rule=terraform_unused_declarations
        - --args=--enable-rule=terraform_typed_variables
@thomaslast thomaslast added area/docker bug Something isn't working labels Apr 6, 2022
@MaxymVlasov
Copy link
Collaborator

Duplicates of #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants