hook terraform validate fails

[loque1]

Hi. I upgraded to terraform 0.15.4 and the terraform_validate hook fails with the following

Terraform validate.......................................................Failed
- hook id: terraform_validate
- exit code: 1

Validation failed: iac/common
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│ 
│   on terraform.tf line 13, in terraform:
│   13:   experiments = [module_variable_optional_attrs]
│ 
│ Experimental features are subject to breaking changes in future minor or
│ patch releases, based on feedback.
│ 
│ If you have feedback on the design of this feature, please open a GitHub
│ issue to discuss it.
╵
╷
│ Error: Could not load plugin
│ 
│ 
│ Plugin reinitialization required. Please run "terraform init".
│ 
│ Plugins are external binaries that Terraform uses to access and manipulate
│ resources. The configuration provided requires plugins which can't be
│ located,
│ don't satisfy the version constraints, or are otherwise incompatible.
│ 
│ Terraform automatically discovers provider requirements from your
│ configuration, including providers used in child modules. To see the
│ requirements and constraints, run "terraform providers".
│ 
│ 2 problems:
│ 
│ - failed to instantiate provider "registry.terraform.io/hashicorp/azuread"
│ to obtain schema: unknown provider
│ "registry.terraform.io/hashicorp/azuread"
│ - failed to instantiate provider "registry.terraform.io/hashicorp/azurerm"
│ to obtain schema: unknown provider
│ "registry.terraform.io/hashicorp/azurerm"
│ 
╵

If I run the command outside of pre-commit in the same directory it all passes fine

╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│ 
│   on terraform.tf line 13, in terraform:
│   13:   experiments = [module_variable_optional_attrs]
│ 
│ Experimental features are subject to breaking changes in future minor or patch releases, based on feedback.
│ 
│ If you have feedback on the design of this feature, please open a GitHub issue to discuss it.
│ 
│ (and 5 more similar warnings elsewhere)
╵
Success! The configuration is valid, but there were some validation warnings as shown above.

Any help on this would be ideal

[mustafababil]

You can try deleting your .terraform folder as you upgraded TF version earlier.

[amontalban]

I'm having the same issue when running in a pipeline in Codefresh with a repository with multiple Terraform modules, I have tried to delete all .terraform folders, do a git clean -f -x and even cloning in a random directory.

I thought #158 would have fixed it but not in my case.

Any idea on how to debug this in a pipeline?

Thanks!

[jimsmith]

I ran into this same issue, the way I got it to work was remove all .terraform directories including one's in modules directories as in my case it was created locally and when this came along it would not bring in the other providers until I nuked the .terraform folders across the project.

Before

Terraform validate.......................................................Failed
- hook id: terraform_validate
- exit code: 1

Validation failed: terraform/modules/aws-vpn-client
╷
│ Error: Could not load plugin
│ 
│ 
│ Plugin reinitialization required. Please run "terraform init".
│ 
│ Plugins are external binaries that Terraform uses to access and manipulate
│ resources. The configuration provided requires plugins which can't be
│ located,
│ don't satisfy the version constraints, or are otherwise incompatible.
│ 
│ Terraform automatically discovers provider requirements from your
│ configuration, including providers used in child modules. To see the
│ requirements and constraints, run "terraform providers".
│ 
│ 2 problems:
│ 
│ - failed to instantiate provider "registry.terraform.io/hashicorp/null" to
│ obtain schema: unknown provider "registry.terraform.io/hashicorp/null"
│ - failed to instantiate provider "registry.terraform.io/hashicorp/template"
│ to obtain schema: unknown provider
│ "registry.terraform.io/hashicorp/template"
│ 
╵

After

 pre-commit run --all-files terraform_validate
Terraform validate.......................................................Passed

[antonbabenko]

I do the same as @jimsmith . Here is my shell function for that:

rm_terraform () {
        find . -name ".terraform*" -print0 | xargs -0 rm -r
}

[MaxymVlasov]

TBD: add workaround to docs

[eytanhanig]

Deleting all .terraform has consequences for local developmen if you're using Terraform workspaces, which create the file .terraform/environment. A better solution for this module would be to add an argument to terraform_validate or create separate hook altogether that specifies cases when you always want to run terraform init before running terraform validate.

[antonbabenko]

Very good point! Let's add support for an argument in terraform_validate like force-init.

[MaxymVlasov]

TBD: add workaround to docs

Done

Issue closing reasons:

• Workaround documented
• Feature for workspaces (where that workaround will not work) separated to feat: Add argument like force-init to do init before terraform validate #224