Skip to content

Commit

Permalink
fix(terraform_docs) Add missing popd to code that was introduced in v…
Browse files Browse the repository at this point in the history
…1.95.0

A bug in the terraform-docs hook was introduced by the code changes in #717.  [A continue statement was added that is not preceded by a `popd` command](https://github.com/antonbabenko/pre-commit-terraform/blob/869a106a4c8c48f34f58318a830436142e31e10a/hooks/terraform_docs.sh#L216).  The bug is only triggered when the hook is processing multiple files where one (or more) of the files does not contain the terraform-docs marker statements.  The hook fails to process the remaining files because the working directory is not reset to the root of the repository.
  • Loading branch information
ryan-at-ld authored Sep 16, 2024
1 parent 869a106 commit a24ea5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hooks/terraform_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ function terraform_docs {
#
if [[ $add_to_existing == false ]]; then
have_marker=$(grep -o "$insertion_marker_begin" "$output_file") || unset have_marker
[[ ! $have_marker ]] && continue
[[ ! $have_marker ]] && popd > /dev/null && continue
fi
# shellcheck disable=SC2086
terraform-docs --output-mode="$output_mode" --output-file="$output_file" $tf_docs_formatter $args ./ > /dev/null
Expand Down

0 comments on commit a24ea5f

Please sign in to comment.