fix when expected input contains line break #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mario-s thanks |
teverett
added a commit
that referenced
this pull request
May 16, 2021
….6.1 Bump maven.version from 3.6.0 to 3.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the phenomenom when there is a line break in the error file.
Assume you have an error file with this content:
line 1:29 mismatched input '\n' expecting 'namespace'
The class AssertErrorsErrorListener was replacing that line but not the actual error message. Therefore you get a mismatch like this:
com.khubla.antlr.antlr4test.AssertErrorsException: namespace.cto.errors : expected (line 1:29 mismatched input '
' expecting 'namespace'), but was (line 1:29 mismatched input '\n' expecting 'namespace')
The change will replace the place holders of the expecting message too.