Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Make BaseGoTest::initializeRuntime static #3422

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Dec 20, 2021

After this its possible to update pom.xml to make the tests parallel, at least for Go. The other test suites may not support that.

diff --git a/runtime-testsuite/pom.xml b/runtime-testsuite/pom.xml
index 9c63282cd..c75dc195a 100644
--- a/runtime-testsuite/pom.xml
+++ b/runtime-testsuite/pom.xml
@@ -106,6 +106,8 @@
                         <include>**/dart/Test*.java</include>
                         <include>${antlr.tests.swift}</include>
                     </includes>
+          <parallel>all</parallel>
+          <useUnlimitedThreads>true</useUnlimitedThreads>
 				</configuration>
 			</plugin>
 			<plugin>

@jcking
Copy link
Collaborator Author

jcking commented Dec 20, 2021

@parrt

@parrt parrt added this to the 4.9.4 milestone Dec 20, 2021
@parrt parrt merged commit ed31d62 into antlr:master Dec 20, 2021
@jcking
Copy link
Collaborator Author

jcking commented Dec 20, 2021

CSharp, Dart, and PHP at least do not support running in parallel. The others do, AFAICT.

@jcking
Copy link
Collaborator Author

jcking commented Dec 20, 2021

Oh, for Dart I might just be missing the runtime. Same for PHP.

Let me just create a pull request that enables parallelism and see what happens.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 20, 2021

All runtimes should support parallel execution.

@jcking
Copy link
Collaborator Author

jcking commented Dec 20, 2021

Not specifically the runtimes, but the tests. Some of the setup is not static but per test case which breaks when you start running them parallely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants