Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 3375: Fix bug when pasing .interp file #3419

Merged
merged 8 commits into from
Dec 25, 2021

Conversation

Tinker1024
Copy link
Contributor

@Tinker1024 Tinker1024 commented Dec 20, 2021

I have rised a issue #3375 when I was reading codes in runtime module.
The bug will lead the parseFile() to strange error.
So I open this PR to fix it.

fixes #3375

Copy link
Member

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parrt Good patch for the Java interpreter data reader and a new test that probably needs a change wrt to the test reorg.

@parrt
Copy link
Member

parrt commented Dec 24, 2021

Hi! Thanks. could you also sign the contributors.txt file? Thanks!

@parrt parrt added this to the 4.9.4 milestone Dec 24, 2021
@parrt
Copy link
Member

parrt commented Dec 24, 2021

@mike-lischke I'll tweak the test upon merging.

@parrt
Copy link
Member

parrt commented Dec 24, 2021

@Tinker1024 please ping with @parrt when you've signed.

@Tinker1024
Copy link
Contributor Author

@Tinker1024 please ping with @parrt when you've signed.
Hi! I have signed the contributors.txt. :-)

@parrt parrt merged commit c4bf6c5 into antlr:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parseFile method of the InterpreterDataReader class is missing code: "line = br.readLine();"
3 participants