-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#, JavaScript, Go runtime tests performance improvements #3365
Merged
ericvergnaud
merged 7 commits into
antlr:master
from
KvanTTT:csharp-runtime-tests-performance
Nov 29, 2021
Merged
C#, JavaScript, Go runtime tests performance improvements #3365
ericvergnaud
merged 7 commits into
antlr:master
from
KvanTTT:csharp-runtime-tests-performance
Nov 29, 2021
+280
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion and use .dll in test projects
…e direct file path to runtime files It has significantly improved performance
KvanTTT
force-pushed
the
csharp-runtime-tests-performance
branch
from
November 28, 2021 12:53
841d309
to
eaed457
Compare
KvanTTT
changed the title
C# runtime tests performance improvements
C# and JavaScript runtime tests performance improvements
Nov 28, 2021
…y test run It has significantly improved performance
KvanTTT
changed the title
C# and JavaScript runtime tests performance improvements
C#, JavaScript, Go runtime tests performance improvements
Nov 28, 2021
It's strange that golang tests work on my Windows machine but don't work on CI machine. I'll investigate. |
…OT redirection instead of GOPATH
KvanTTT
force-pushed
the
csharp-runtime-tests-performance
branch
from
November 28, 2021 21:50
5d1e953
to
7a87cdc
Compare
It's strange that this branch is green but master is red. There are failing dotnet and go tests on Linux. The problem with go is probably is outdated version. The problem with C# is incompatible target in It would be great to show all tests for every branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added compilation of C# runtime project before the test session. After that, each test use compiled assembly instead of referencing to
.csproj
and extra compilation.For Node I've removed npm packaging and implemented referencing right on runtime files.
For Go I've added GOROOT redirecting and removed extra copying of runtime files on every test.
There is the table with optimization results:
Now runtime tests work much faster and use much less IO operations.