Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites usages in pom.xml #3102

Open
khmarbaise opened this issue Mar 1, 2021 · 1 comment
Open

Prerequisites usages in pom.xml #3102

khmarbaise opened this issue Mar 1, 2021 · 1 comment

Comments

@khmarbaise
Copy link
Contributor

khmarbaise commented Mar 1, 2021

Based on the usage of

<prerequisites>
   ...
</prerequisites>

The build produces the following warnings:

[INFO] Scanning for projects...
[WARNING] The project org.antlr:antlr4-runtime-testsuite:jar:4.9.2-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[WARNING] The project org.antlr:antlr4-tool-testsuite:jar:4.9.2-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 

The <prerequities>..</prerequities> makes only for the antlr4-maven-plugin sense. All other parts should be checked via maven-enforcer-plugin instead.

The minimum to be required for the antl4-maven-plugin should be 3.0.5 instead of 3.0, because 3.0.0 contains a lot of bugs etc. Apart from that based on the dependencies defined in the antlr4-maven-plugin the level should be lifted to minimum requirement for the plugin to 3.3.9

The minimum to build the whole antlr project is from my point of view 3.3.9 or even higher. But I would suggest to set the minimum level to 3.3.9.

Based on the usage of the takari lilfecycle you have to build at least with Maven 3.2.1

@chris-miner
Copy link
Contributor

I was going to write this up as a discussion, when I thought to check if it was already an issue. Now that I found the issue and a related commit, I figured there would be a PR. I can't find a PR from @khmarbaise. @khmarbaise are these changes part of a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants