This repository has been archived by the owner on May 20, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a little clearer when e.g. we’re referring to `String` (a term in scope) vs. `Swift.String` (an embedded value used to define the term).
… to be equal. This is terrible.
type: String.ref --> List[Character.ref], | ||
value: () => { (string: Term) -> Term in | ||
guard case let .Embedded(value as Swift.String, _, _) = string.out else { return ("toList" as Term)[string] } | ||
return toTerm(value.characters) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect.
We evaluate this function when the value term is constructed, not when the defined toList
term is evaluated. Therefore, it always fails the guard
clause, produces itself in neutral form, and diverges during evaluation.
… function. It’s unclear why Swift’s overload selection rules chose that one in the first place.
This was referenced Dec 13, 2015
This is incorrect: it always produces the empty string. But it’s a start.
This turns out to be false!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String
module which embeds Swift’s strings into Manifold.String.toList
function behaves correctly.String.fromList
function.String.fromList
function behaves correctly.