Fixed sdscat*() bug: read memory error

antirez · Jul 6, 2020 · 91798d8 · 91798d8
1 parent 78df725
commit 91798d8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/a.out b/a.out
diff --git a/main.c b/main.c
@@ -0,0 +1,17 @@
+#include <stdio.h>
+
+#include "sds.h"
+
+int
+main(void)
+{
+	sds str;
+
+	str = sdsnew("asdf");
+	str = sdscat(str, str);
+	printf("%s\n", str);
+
+	sdsfree(str);
+
+	return 0;
+}
diff --git a/sds.c b/sds.c
@@ -399,7 +399,7 @@ sds sdscatlen(sds s, const void *t, size_t len) {
 
     s = sdsMakeRoomFor(s,len);
     if (s == NULL) return NULL;
-    memcpy(s+curlen, t, len);
+    memmove(s+curlen, t, len);
     sdssetlen(s, curlen+len);
     s[curlen+len] = '\0';
     return s;