Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type for bulk requests for Elastic search versions less than 7 #59

Merged
merged 4 commits into from
Jul 5, 2019

Conversation

ShyamKunda
Copy link
Contributor

@ShyamKunda ShyamKunda commented Jul 4, 2019

Issue we are getting with Elastic search listener 2.6.5 and Elastic Search versions less than 7 .
ERROR i.g.d.j.b.e.ElasticSearchMetricSender: Exceptionorg.elasticsearch.client.ResponseException: method [POST], host [http://abc-analytics-elastic.xyx.net:9200], URI [/jmeter/_bulk], status line [HTTP/1.1 400 Bad Request] {"error":{"root_cause":[{"type":"action_request_validation_exception","reason":"Validation Failed: 1: type is missing;"}],"type":"action_request_validation_exception","reason":"Validation Failed: 1: type is missing;"},"status":400} 2019-07-04 11:20:55,244 ERROR i.g.d.j.b.e.ElasticSearchMetricSender: ElasticSearch Backend Listener was unable to perform request to the ElasticSearch engine. Check your JMeter console for more info. 2019-07-04 11:20:55,245 INFO o.a.j.g.u.JMeterMenuBar: setRunning(false, *local*)

@ShyamKunda ShyamKunda changed the title Fixing missing types from bulk requests Added type for bulk requests for Elastic search versions less than 7 Jul 4, 2019
@anthonygauthier
Copy link
Owner

anthonygauthier commented Jul 4, 2019

@ShyamKunda : To avoid creating overhead, I changed where you were getting the version of the ElasticSearch instance (from the sendRequest() method to the setupTest() method). Would it be possible for you to still test if everything is okay with this?

If it is, I'll merge both the changes and release a new version.
Thanks,

@anthonygauthier anthonygauthier merged commit 0b89803 into anthonygauthier:master Jul 5, 2019
@ShyamKunda
Copy link
Contributor Author

@ShyamKunda : To avoid creating overhead, I changed where you were getting the version of the ElasticSearch instance (from the sendRequest() method to the setupTest() method). Would it be possible for you to still test if everything is okay with this?

If it is, I'll merge both the changes and release a new version.
Thanks,

Tested with Elastic search version 6.7.0 and 7.2.0. It is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants