Fixed Video full-screen not working

anthonycr · Jul 22, 2014 · 60574c0 · 60574c0
1 parent ae40af0
commit 60574c0
Showing 1 changed file with 24 additions and 22 deletions.
diff --git a/src/acr/browser/lightning/LightningView.java b/src/acr/browser/lightning/LightningView.java
@@ -1005,21 +1005,22 @@ public void onHideCustomView() {
 
 		@Override
 		public void onShowCustomView(View view, CustomViewCallback callback) {
-
-			if (view instanceof FrameLayout) {
-				FrameLayout frame = (FrameLayout) view;
-				if (frame.getFocusedChild() instanceof VideoView) {
-					VideoView video = (VideoView) frame.getFocusedChild();
-					video.stopPlayback();
-					frame.removeView(video);
-					video.setVisibility(View.GONE);
-				}
-			} else {
+		// While these lines might look like they work, in practive,
+		// Full-screen videos won't work correctly. I may test this out some more
+		//	if (view instanceof FrameLayout) {
+		//		FrameLayout frame = (FrameLayout) view;
+		//		if (frame.getFocusedChild() instanceof VideoView) {
+		//			VideoView video = (VideoView) frame.getFocusedChild();
+		//			video.stopPlayback();
+		//			frame.removeView(video);
+		//			video.setVisibility(View.GONE);
+		//		}
+		//	} else {
 				Activity activity = mBrowserController.getActivity();
 				mBrowserController.onShowCustomView(view,
 						activity.getRequestedOrientation(), callback);
 
-			}
+		//	}
 
 			super.onShowCustomView(view, callback);
 		}
@@ -1028,20 +1029,21 @@ public void onShowCustomView(View view, CustomViewCallback callback) {
 		@Deprecated
 		public void onShowCustomView(View view, int requestedOrientation,
 				CustomViewCallback callback) {
-
-			if (view instanceof FrameLayout) {
-				FrameLayout frame = (FrameLayout) view;
-				if (frame.getFocusedChild() instanceof VideoView) {
-					VideoView video = (VideoView) frame.getFocusedChild();
-					video.stopPlayback();
-					frame.removeView(video);
-					video.setVisibility(View.GONE);
-				}
-			} else {
+		// While these lines might look like they work, in practive,
+		// Full-screen videos won't work correctly. I may test this out some more
+		//	if (view instanceof FrameLayout) {
+		//		FrameLayout frame = (FrameLayout) view;
+		//		if (frame.getFocusedChild() instanceof VideoView) {
+		//			VideoView video = (VideoView) frame.getFocusedChild();
+		//			video.stopPlayback();
+		//			frame.removeView(video);
+		//			video.setVisibility(View.GONE);
+		//		}
+		//	} else {
 				mBrowserController.onShowCustomView(view, requestedOrientation,
 						callback);
 
-			}
+		//	}
 
 			super.onShowCustomView(view, requestedOrientation, callback);
 		}