Skip to content

Commit

Permalink
chore(release): fix documentation update task (karma-runner#3551)
Browse files Browse the repository at this point in the history
The task has never succeeded because there was a typo in the repository URL.
See https://travis-ci.org/github/karma-runner/karma/jobs/722815882#L1324

But build has never failed either, because "The exit code of after_success, after_failure, after_script, after_deploy and subsequent stages do not affect the build result." according to Travis [documentation](https://docs.travis-ci.com/user/job-lifecycle/#breaking-the-build) and this code was run in `after_success` stage. This should be fixed in a separate PR though.
  • Loading branch information
devoto13 authored Sep 2, 2020
1 parent beed255 commit 4b3a469
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/update-docs.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const success = async (pluginConfig, { nextRelease, logger }) => {
// button on GitHub. The only added part is GH_TOKEN value in the `userinfo`
// part of the URL (https://en.wikipedia.org/wiki/URL), which allows GitHub
// to authenticate a user and authorise the push to the repository.
const repoOrigin = `https://${process.env.GH_TOKEN}@github.com/karma/karma-runner.github.com.git`
const repoOrigin = `https://${process.env.GH_TOKEN}@github.com/karma-runner/karma-runner.github.com.git`

const options = { encoding: 'utf8', cwd: docsPath }

Expand Down

0 comments on commit 4b3a469

Please sign in to comment.