docs: setup and cli installation details #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
reviewed
Oct 4, 2023
| # CLI Installation with Cargo | ||
|
|
||
| ## Prerequisites | ||
| The best way to build Arbiter today is from source. |
There was a problem hiding this comment.
I would actually say that it's much easier to install from crates with cargo install arbiter than from the source. I think it's good to include instructions for both but i crates is easier because you don't have to build from src.
There was a problem hiding this comment.
good point. will rework this part and probably just nix this particular line
0xJepsen
requested changes
Oct 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 11 11
Lines 3722 3722
=======================================
Hits 2187 2187
Misses 1535 1535 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Paging @Autoparallel or @kinrezC for a review here |
Autoparallel
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an overview of the tasks completed
Link to issue(s) that this PR closes
Resolves #557