Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reciepts #483

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Feat/reciepts #483

merged 8 commits into from
Sep 11, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Sep 8, 2023

Give an overview of the tasks completed
This PR populates the transaction receipts with full information.

Link to issue(s) that this PR closes
closes #479

This PR will also get the tests to pass in the v0.5.0 feature branch.

I noticed two things while working on this. Particularly when working on the transaction hash.

  • The tx hash of course depends on rlp encodings of a collection of fields in the tx, there are some nice abstractions for this that i was looking at in this reth crate that i think we should use in the future. However right now it is not implemented for revm and ethers types (pending alloy migrations) and i think the current implementation is sufficient.
  • The encoding does depend on the nonce which we aren't incrementing or bookkeeping for the clients. I think the way to go would be to implement the nonce manager here

@0xJepsen 0xJepsen linked an issue Sep 8, 2023 that may be closed by this pull request
@0xJepsen 0xJepsen marked this pull request as ready for review September 8, 2023 20:09
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing something here as far as I can tell. In environment.rs lines 346-366 we should be reseting the transaction index and gas count.

@0xJepsen
Copy link
Collaborator Author

Nice thought. I pushed changes to address this!

@Autoparallel Autoparallel merged commit 0c96d20 into feat(arbiter-core)/v0.5.0 Sep 11, 2023
@Autoparallel Autoparallel deleted the feat/reciepts branch September 19, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: send gas cost in tx receipt
2 participants