Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update init.rs ✨ #408

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update init.rs ✨ #408

merged 1 commit into from
Jul 26, 2023

Conversation

0xJepsen
Copy link
Collaborator

Fix init.rs
update paths

@0xJepsen
Copy link
Collaborator Author

Closes #406

@0xJepsen 0xJepsen added this to the Arbiter CLI milestone Jul 25, 2023
@0xJepsen 0xJepsen linked an issue Jul 25, 2023 that may be closed by this pull request
Arbiter Init #406
Closed
@0xJepsen
Copy link
Collaborator Author

Put bindings in .gitignore

@0xJepsen
Copy link
Collaborator Author

Maybe add a log to inform users that revert strings are on
https://github.com/primitivefinance/arbiter/blob/fd779c8effff44c8f8118e2465d84598559528f9/bin/bind.rs#L6C1-L7C1

@0xJepsen
Feedback
cd4e94c 
🦀
@Autoparallel
Copy link
Collaborator

Put bindings in .gitignore

did you do this @0xJepsen ?

Autoparallel
Autoparallel approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Autoparallel Autoparallel merged commit 296ea8f into main Jul 26, 2023
@0xJepsen 0xJepsen deleted the waylon/init branch August 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

@Alexangelj Alexangelj Awaiting requested review from Alexangelj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arbiter Init
2 participants
@0xJepsen @Autoparallel