[BUG FIX] Message not delivered to Processor #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the cluster tests are very flakey. I needed to trigger the build a few times to get them to pass. |
|
@troygilman0 The test are indeed scuffed, do to the "async" nature and probably the skill issue on my end as well. Been thinking about it for a long time to rewrite those. |
|
Nice found my man! Thank you a lot for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bugfix for issue #173.
We must check if the ring-buffer has messages after transitioning the procStatus to "idle". If there are messages, then we should schedule again.
I added a test that can somewhat reliably reproduce the issue. However, the test takes about 2 seconds to run on my machine.