feat: support type-aware rules #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauliesnug
approved these changes
Aug 3, 2024
RebeccaStevens
changed the title
RebeccaStevens
added a commit
to eslint-functional/eslint-plugin-functional
that referenced
this pull request
Aug 5, 2024
|
@antfu ping |
antfu
approved these changes
Aug 12, 2024
src/rule-tester.ts
Outdated
Comment on lines
44
to
45
| jsx: 'react.jsx', | ||
| tsx: 'react.tsx', |
There was a problem hiding this comment.
Suggested change
| jsx: 'react.jsx', | |
| tsx: 'react.tsx', | |
| jsx: 'file.jsx', | |
| tsx: 'file.tsx', |
Wouldn't it better just having file and be more natural? Any reason react is needed?
There was a problem hiding this comment.
That's just how typescript-eslint does it for their tester so I just copied them.
|
@antfu Is there any docs for this change? If not that's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for testing type-aware rules.
Linked Issues
fixes #4