-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preserve yaml anchors and aliases w/ single string value when updating pnpm-workspace.yaml
#153
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the use case below
defines:
- &react ^18.2.0
catalog:
react: *react
react-dom: *react
It's not working in this PR.
Thanks for the rapid reply❤️, but the test parts are not finished yet. Currently, the tests cannot And I'm wondering if we should support this use case, though this use case make sense, but it's not a valid yaml-schema for |
Co-authored-by: Kevin Deng 三咲智子 <[email protected]>
pnpm doesn't prohibit adding unknown fields. I'm not sure if this is a good use case, but my repository currently uses it this way. |
Description
PackageMeta
, originally as an interface, is turned into a union type, andGlobalPackageMeta
is exportedraw
cannot provide more precise information,yaml
'sDocument
model is used to find anchors and aliases, thusjs-yaml
is dropped.Linked Issues
fix #150
Additional context