Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: preserve yaml anchor and alias when bump pnpm catalog #150

Open
3 tasks done
ntnyq opened this issue Jan 13, 2025 · 1 comment · May be fixed by #153
Open
3 tasks done

Feature: preserve yaml anchor and alias when bump pnpm catalog #150

ntnyq opened this issue Jan 13, 2025 · 1 comment · May be fixed by #153
Labels
enhancement New feature or request pr welcome

Comments

@ntnyq
Copy link
Contributor

ntnyq commented Jan 13, 2025 •
edited
Loading

Clear and concise description of the problem

For pnpm-workspace.yaml:

Before

catalog:
  unocss: &unocss ^0.65.4
  "@unocss/preset-icons": *unocss
  "@unocss/preset-uno": *unocss
  "@unocss/vite": *unocss
packages:
  - .

After

catalog:
  "@unocss/preset-icons": ^65.4.0
  "@unocss/preset-uno": ^65.4.0
  "@unocss/vite": ^65.4.0
  unocss: ^65.4.0
packages:
  - .

Expected

# pnpm-workspace.yaml
catalog:
  unocss: &unocss ^65.4.0
  "@unocss/preset-icons": *unocss
  "@unocss/preset-uno": *unocss
  "@unocss/vite": *unocss
packages:
  - .

Suggested solution

Don't have any clue for now, I'll check the source code.

Alternative

No response

Additional context

There is an repro repo for this.

Validations
@ntnyq ntnyq added the enhancement New feature or request label Jan 13, 2025
@younggglcy younggglcy linked a pull request Jan 30, 2025 that will close this issue
Open
@sxzz
Copy link
Member

sxzz commented Feb 2, 2025

@younggglcy IMHO, using AST modifications might better support complex cases. Re-serialization can lose information like comments, anchors, and aliases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pr welcome
Projects
None yet
Milestone
No milestone
3 participants
@sxzz @antfu @ntnyq