Merge branch '#52' into master. fixed #51

antchfx · Mar 1, 2021 · e73954f · e73954f
2 parents 9367e2f + f1467a4
commit e73954f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/node.go b/node.go
@@ -93,7 +93,7 @@ func outputXML(buf *bytes.Buffer, n *Node, preserveSpaces bool) {
 		return
 	case CharDataNode:
 		buf.WriteString("<![CDATA[")
-		xml.EscapeText(buf, []byte(n.sanitizedData(preserveSpaces)))
+		buf.WriteString(n.Data)
 		buf.WriteString("]]>")
 		return
 	case CommentNode:

diff --git a/node_test.go b/node_test.go
@@ -410,3 +410,13 @@ func TestOutputXMLWithSpaceOverwrittenToDefault(t *testing.T) {
 	}
 	t.Log(n.OutputXML(false))
 }
+
+
+func TestOutputXMLWithXMLInCDATA(t *testing.T) {
+	s := `<?xml version="1.0" encoding="utf-8"?><node><![CDATA[<greeting>Hello, world!</greeting>]]></node>`
+	doc, _ := Parse(strings.NewReader(s))
+	t.Log(doc.OutputXML(false))
+	if doc.OutputXML(false) != s {
+		t.Errorf("the outputted xml escaped CDATA section")
+	}
+}