This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Skip pattern synonyms + Warn about skipped definitions #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI is not happy because you added those warnings, and now the generated |
Use simple pattern-matching instead
- Skip pattern synonyms rather than error
Lysxia
commented
Oct 18, 2020
| | f, cons x xs => foldl' f x xs | ||
| | _, nil => errorEmptyList (GHC.Base.hs_string__ "foldl1'") | ||
| end. | ||
|
|
There was a problem hiding this comment.
I'm not sure why this order changed...
There was a problem hiding this comment.
Odd, but this should be fine...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #164. One day there should be some way of actually translating them, but just skipping them can already be helpful to handle some existing modules such as
Data.Sequence.Internalin containers.I also added some warnings because I got confused about whether I was doing something wrong when something wasn't getting translated, for example: