Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bubble support more variant #140

Merged
merged 7 commits into from
Oct 9, 2024
Merged

feat: Bubble support more variant #140

merged 7 commits into from
Oct 9, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 9, 2024

image

antd 新的 minor 更新了 Button 的变体 classNames,这边同步更新一下 snapshot。

Summary by CodeRabbit

  • 新功能

    • 引入了新的 Bubble 组件变体,包括 "filled"、"outlined" 和 "shadow"。
    • 组件布局改为使用 Flex 组件,增强了视觉表现。
  • 样式更新

    • 添加了针对不同 Bubble 变体的样式生成逻辑。
    • 修改了标题元素的样式,调整了其间距。
  • 依赖更新

    • 更新了 antd 依赖版本,并新增了 @emotion/server 依赖。

Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

该拉取请求对多个文件进行了修改,主要集中在 Bubble 组件的变体和样式上。在 components/bubble/demo/variant.tsx 中新增了 Flex 组件以垂直排列多个 Bubble 组件,并更新了 variant 属性以支持新的样式变体。components/bubble/interface.ts 更新了 BubbleProps 接口以包含更多变体选项。components/bubble/style/index.tscomponents/bubble/style/variant.ts 引入了新的样式生成逻辑,增强了组件的样式处理。package.json 文件进行了格式化和依赖更新。

Changes

文件路径 更改摘要
components/bubble/demo/variant.tsx 新增 Flex 组件,更新 Bubble 组件的 variant 属性,包括 "filled"、"outlined" 和 "shadow" 三个新变体。
components/bubble/interface.ts 更新 BubbleProps 接口的 variant 属性,新增 'outlined''shadow' 选项。
components/bubble/style/index.ts 新增 genVariantStyle 导入,更新 genBubbleStyle 函数,包含变体样式生成。
components/bubble/style/variant.ts 新增 genVariantStyle 函数,根据 BubbleToken 生成变体样式。
components/prompts/style/index.ts 更新 genPromptsStyle 函数,新增标题元素的样式规则。
package.json 格式化数组,更新 antd 依赖版本,新增 @emotion/server 依赖。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Bubble
    participant Style

    User->>App: 请求展示 Bubble 组件
    App->>Bubble: 渲染多个 Bubble 变体
    Bubble->>Style: 请求样式
    Style-->>Bubble: 返回样式
    Bubble-->>App: 返回渲染结果
    App-->>User: 显示 Bubble 组件
Loading

Poem

🐰 在这个新版本中,
变体如花绽放,
填充、轮廓与阴影,
风格多样,乐无穷。
兔子欢跳,庆新生,
组件美丽,心情好! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ba5c398 and 3c62090.

⛔ Files ignored due to path filters (1)
  • bun.lockb is excluded by !**/bun.lockb
📒 Files selected for processing (1)
  • package.json (5 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Oct 9, 2024

Preview is ready

Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7944aff
Status: ✅  Deploy successful!
Preview URL: https://bba59d42.x-73x.pages.dev
Branch Preview URL: https://bubble-variant.x-73x.pages.dev

View logs

Copy link
Contributor

@ONLY-yours ONLY-yours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zombieJ zombieJ merged commit 636eaba into main Oct 9, 2024
9 checks passed
@zombieJ zombieJ deleted the bubble-variant branch October 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants