Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature UserRegister migrate antd@4 #164

Merged
merged 7 commits into from
Jan 20, 2020
Merged

Feature UserRegister migrate antd@4 #164

merged 7 commits into from
Jan 20, 2020

Conversation

txp1035
Copy link
Contributor

@txp1035 txp1035 commented Jan 19, 2020

#158

@txp1035 txp1035 changed the title Feature UserRegister migrate antd@4 [WIP]Feature UserRegister migrate antd@4 Jan 19, 2020
@txp1035
Copy link
Contributor Author

txp1035 commented Jan 19, 2020

121
bug:
由于成功和失败验证会导致输入框高度变化,rc-tooltips的top是更具子元素高度计算值的。所以出现不同状态tooltips抖动现象。
解决方案:
1、更改rc-tooltips定位方案。
2、修改antd的form组件,如果为空不渲染错误节点。
image
antd pr 地址
个人认为第二种方案比较合理

最终解决方案:通过设置help=""来吃掉错误节点

新问题

last(3.x)版本设置help=""可以吃掉错误节点,next(4.x)版本不行
last(3.x)版本错误节点渲染机制
image
next(4.x)渲染
image
next版本在help为空的时候不能吃掉错误节点

@chenshuai2144 @zombieJ

@txp1035 txp1035 changed the title [WIP]Feature UserRegister migrate antd@4 Feature UserRegister migrate antd@4 Jan 19, 2020
@txp1035 txp1035 changed the title Feature UserRegister migrate antd@4 [WIP]Feature UserRegister migrate antd@4 Jan 20, 2020
@txp1035
Copy link
Contributor Author

txp1035 commented Jan 20, 2020

最后通过暴力设置样式来除掉错误子节点

@txp1035 txp1035 changed the title [WIP]Feature UserRegister migrate antd@4 Feature UserRegister migrate antd@4 Jan 20, 2020
@chenshuai2144 chenshuai2144 merged commit fc80deb into ant-design:antd@4 Jan 20, 2020
chenshuai2144 added a commit that referenced this pull request Mar 10, 2020
* 升级 antd

* Form basic form (#160)

* feat: update to antd@4

* feat: update to antd@4

* Form advanced form (#161)

* feat: update to antd@4

* feat: update to antd@4

* feat: update to antd@4

* chore: remove css

* fix: false deletion

* 升级Editor相关区块的Form到v4 (#163)

* Migrate Account Center to antd@4

* Migrate AccountSettings Center to antd@4

* Migrate DashboardAnalysis  to antd@4

* feat: 升级ListCardList到v4

* feat: 升级ListSearchApplications升级到v4

* feat: 升级ListBasicList到v4

* feat: 升级ListSearchArticle到v4

* feat: 升级ListSearchProjects到v4

* feat: 升级ListTableList到v4

* fix: 去掉LegacyIcon

* fix: 编辑器相关区块使用v4的Form

1. EditorFlow
2. EditorKoni
3. EditorMind

Co-authored-by: 陈帅 <[email protected]>

* Feature AccountSettings migrate antd@4 (#162)

* feat: Feature AccountSettings migrate antd@4

* chore: remove @ant-design/compatible

* FormStepForm  Feature  migrate antd@4 (#159)

* Migrate FormStepForm to antd@4

* review: optimization and adjustment

* refactor: change the writing method to hooks

* ListBasicList and ListSearchApplications Feature migrate antd@4 (#166)

* feat: ListBasicList Feature migrate antd@4

* feat: ListSearchApplications Feature migrate antd@4

* Midou antd4 (#169)

* feat: midou

* feat: songxue antd4 ListTableList

* Feature UserRegister migrate antd@4 (#164)

* feat: 纯函数实现

* fix: Popover不更新

* feat: 清理log注释

* feat: 清理log

* fix: 抖动问题

* fix: 字符串为空显示提示

* style: 空行

* feat:refactoring with antd (#167)

* chore: remove ant-design/compatible

* up @ant-design/pro-table version

close #ant-design/ant-design-pro#5940

* 修复依赖冲突

* fix lint warning

* feat: List Search Projects (#179)

* feat: List Search Projects

* style: fix lint

* style: change eslint rule

* chore: fix lint

* chore: update @umijs/fabric

* List search articles (#176)

* feat: List Search Articles

* chore: style

* chore: reset list search projects

* style: code style

* bugfix: fix login style error

* upgrade @antv/data-set

* ➖ dependency: remove antd@4

* 🔥 clean: fix lint error

* 👷 CI: lint add pretter script

Co-authored-by: 陈小聪 <[email protected]>
Co-authored-by: damon.chen <[email protected]>
Co-authored-by: wangxingkang <[email protected]>
Co-authored-by: Qhan W <[email protected]>
Co-authored-by: LWX <[email protected]>
Co-authored-by: 鬼厉 <[email protected]>
Co-authored-by: xiaohuoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants