Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test case #52224

Merged
merged 2 commits into from
Jan 3, 2025
Merged

test: fix test case #52224

merged 2 commits into from
Jan 3, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 3, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

Copy link

stackblitz bot commented Jan 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zombieJ zombieJ changed the base branch from master to feature January 3, 2025 08:49
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Jan 3, 2025

👁 Visual Regression Report for PR #52224 Failed ❌

🎯 Target branch: feature (9fcce8f)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
button-color-variant.dark.png button-color-variant.dark.png button-color-variant.dark.css-var.png button-color-variant.dark.css-var.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.png
button-debug-color-variant.compact.png button-debug-color-variant.compact.png button-debug-color-variant.compact.css-var.png button-debug-color-variant.compact.css-var.png
button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.png
button-debug-color-variant.dark.png button-debug-color-variant.dark.png button-debug-color-variant.dark.css-var.png button-debug-color-variant.dark.css-var.png
button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.png
button-debug-color-variant.default.png button-debug-color-variant.default.png button-debug-color-variant.default.css-var.png button-debug-color-variant.default.css-var.png
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 8 diffs found in this PR: 🔄 8 changed.
Please check all items:

  • Visual diff is acceptable

Copy link

socket-security bot commented Jan 3, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 4.04 kB typicode
npm/[email protected] None 0 8.38 kB keyanzhang

View full report↗︎

Copy link

Walkthrough

This pull request focuses on enhancing the test cases and updating various components within the codebase. Key changes include the introduction of new test cases, updates to component styles, and the addition of new features such as preset colors and responsive design elements. The updates aim to improve the overall functionality and user experience of the components.

Changes

Files Summary
.dumi/components/SemanticPreview.tsx Added logic to calculate and set position for marking elements.
.dumi/pages/index/components/Theme/ColorPicker.tsx Updated ColorPicker presets to include a key attribute.
.dumi/pages/index/components/Theme/index.tsx Replaced TinyColor with FastColor for color manipulation.
.dumi/theme/builtins/ColorChunk/index.tsx Changed color manipulation library from TinyColor to FastColor.
.dumi/theme/builtins/ComponentTokenTable/index.tsx Updated Popover styles to use a new styles object.
.dumi/theme/builtins/TokenCompare/index.tsx Switched from TinyColor to FastColor for color conversion.
.dumi/theme/builtins/TokenTable/index.tsx Adjusted token value access to use TypeScript's keyof.
.dumi/theme/common/styles/Markdown.tsx Updated color manipulation to use FastColor.
.dumi/theme/slots/Footer/index.tsx Replaced TinyColor with FastColor for background color calculation.
.dumi/theme/slots/Header/index.tsx Updated Popover class names to use a new classNames object.
components/avatar/tests/Avatar.test.tsx Modified Popover props to use new classNames and styles objects.
components/avatar/group.tsx Updated Popover class names to use a new classNames object.
components/button/DefaultLoadingIcon.tsx Renamed LoadingIcon to DefaultLoadingIcon and updated its usage.
components/button/tests/index.test.tsx Added tests for preset colors and variants in Button component.
components/button/button.tsx Enhanced loading prop to accept a custom icon.
components/button/buttonHelpers.tsx Extended ButtonColorTypes to include PresetColors.
components/button/demo/color-variant.tsx Added demo for new color variants in Button component.
components/button/demo/loading.md Updated documentation to include custom loading icon feature.
components/button/demo/loading.tsx Added example for custom loading icon in Button component.
components/button/index.en-US.md Documented new preset colors and loading icon feature.
components/button/style/index.ts Added styles for new preset colors in Button component.
components/calendar/demo/week.md Added documentation for showWeek prop in Calendar component.
components/calendar/demo/week.tsx Added example for showWeek prop in Calendar component.
components/calendar/generateCalendar.tsx Introduced showWeek prop for Calendar component.
components/calendar/index.en-US.md Documented showWeek prop in Calendar component.
components/calendar/style/index.ts Added styles for week number display in Calendar component.
components/card/demo/component-token.tsx Added new token properties for Card component styling.
components/card/style/index.ts Updated Card component styles to use new token properties.
components/cascader/demo/component-token.md Added documentation for Cascader component tokens.
components/cascader/demo/component-token.tsx Added example for Cascader component tokens.
components/cascader/style/columns.ts Updated Cascader styles to use new token properties.
components/collapse/style/index.ts Added focus styles to Collapse component.
components/color-picker/ColorPicker.tsx Updated ColorPicker styles to use new styles object.
components/color-picker/tests/index.test.tsx Added tests for ColorPicker presets with key attribute.
components/color-picker/components/ColorPresets.tsx Updated preset key generation logic in ColorPresets.
components/color-picker/demo/panel-render.tsx Added key attribute to ColorPicker presets.
components/color-picker/index.en-US.md Documented key attribute for ColorPicker presets.
components/config-provider/tests/theme.test.tsx Adjusted CSS variable formatting in tests.
components/config-provider/context.ts Added new configuration types for various components.
components/config-provider/cssVariables.ts Replaced TinyColor with FastColor for CSS variable generation.
components/config-provider/index.en-US.md Documented new configuration options for components.
components/descriptions/Cell.tsx Added styles and classNames props to Descriptions component.
components/descriptions/DescriptionsContext.ts Introduced context for Descriptions component styles.
components/descriptions/Item.ts Added styles and classNames props to Descriptions component.
components/descriptions/Row.tsx Updated Descriptions component to use new styles and classNames.
components/descriptions/tests/index.test.tsx Added tests for custom styles in Descriptions component.
components/descriptions/demo/_semantic.tsx Added semantic demo for Descriptions component.
components/descriptions/demo/style.tsx Updated Descriptions demo to use new styles prop.
components/descriptions/index.en-US.md Documented new styles and classNames props for Descriptions.
components/descriptions/index.tsx Added styles and classNames props to Descriptions component.
components/dropdown/index.en-US.md Documented loading icon feature for Dropdown component.
components/empty/tests/index.test.tsx Added tests for custom styles in Empty component.
components/empty/demo/_semantic.tsx Added semantic demo for Empty component.
components/empty/demo/customize.tsx Updated Empty demo to use new styles prop.
components/empty/empty.tsx Added styles and classNames props to Empty component.
components/empty/index.en-US.md Documented new styles and classNames props for Empty.
components/grid/col.tsx Extended ColProps to include responsive breakpoints.
components/grid/style/index.ts Added utility function for media size retrieval.
components/input/Search.tsx Refactored Input props handling in Search component.
components/input/demo/tooltip.tsx Updated Tooltip demo to use new classNames prop.
components/input/style/index.ts Added focus styles to Input component.
components/mentions/index.en-US.md Documented onPopupScroll event for Mentions component.
components/menu/MenuItem.tsx Updated Tooltip class names to use new classNames object.
components/menu/style/index.ts Added

Copy link
Contributor

github-actions bot commented Jan 3, 2025

size-limit report 📦

Path Size
dist/antd.min.js 441.16 KB
dist/antd-with-locales.min.js 509.38 KB

Copy link

pkg-pr-new bot commented Jan 3, 2025

Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: c8b9de7
Status: ✅  Deploy successful!
Preview URL: https://b8d36e65.ant-design.pages.dev
Branch Preview URL: https://fix-test.ant-design.pages.dev

View logs

Copy link

codecov bot commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 2.45kB (0.07%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.37MB 2.45kB (0.07%) ⬆️

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9fcce8f) to head (c8b9de7).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #52224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13754     13754           
  Branches      3595      3595           
=========================================
  Hits         13754     13754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 6139162 into feature Jan 3, 2025
44 checks passed
@zombieJ zombieJ deleted the fix-test branch January 3, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants