feat: CP support Tabs addIcon & moreIcon #47274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c8e83f:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 734 734
Lines 12589 12590 +1
Branches 3294 3294
=========================================
+ Hits 12589 12590 +1 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Feb 1, 2024
components/tabs/index.tsx
Outdated
| @@ -69,7 +70,7 @@ const Tabs: React.FC<TabsProps> & { TabPane: typeof TabPane } = (props) => { | |||
| onEdit?.(editType === 'add' ? event : key!, editType); | |||
| }, | |||
| removeIcon: <CloseOutlined />, | |||
| addIcon: addIcon || <PlusOutlined />, | |||
| addIcon: addIcon ?? tabs?.addIcon ?? <PlusOutlined />, | |||
Signed-off-by: lijianan <[email protected]>
MadCcc
approved these changes
Feb 1, 2024
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge