feat: filter without close dropdown (#28652) #28688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6586d8:
|
|
Size Change: +45 B (0%) Total Size: 796 kB
ℹ️ View Unchanged
|
afc163
reviewed
Jan 5, 2021
afc163
reviewed
Jan 5, 2021
| type="link" | ||
| size="small" | ||
| onClick={() => { | ||
| confirm(false); |
There was a problem hiding this comment.
Suggested change
| confirm(false); | |
| confirm({ closeDropdown: false }); |
afc163
approved these changes
Jan 5, 2021
afc163
reviewed
Jan 5, 2021
| size="small" | ||
| onClick={() => { | ||
| confirm({ closeDropdown: false }); | ||
| console.log('1234'); |
1 task
|
@afc163 ,请问这个PR怎么没有merge到master |
我本想看一下为什么，但是奈何github同步不下来 😂，好慢 |
|
4.10.0的minor版本是7天前，你这个是6天前，得等下个minor了，也就是月底的4.11.0. |
|
好的，明白了，谢谢 |
collinbarrett
added a commit
to collinbarrett/FilterLists
that referenced
this pull request
Jan 26, 2021
collinbarrett
added a commit
to collinbarrett/FilterLists
that referenced
this pull request
Jan 26, 2021
collinbarrett
added a commit
to collinbarrett/FilterLists
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
[#28652]
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge
View rendered components/table/demo/custom-filter-panel.md