Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Standalone Badge motion style #28240

Merged
merged 3 commits into from
Dec 7, 2020
Merged

fix: Standalone Badge motion style #28240

merged 3 commits into from
Dec 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 7, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #28231

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge standalone motion blink when show/hide.
🇨🇳 Chinese 修复 Badge 独立使用是展示、收起动画跳动的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/badge/demo/no-wrapper.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 7, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020

Size Change: +248 B (0%)

Total Size: 789 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +12 B (0%)
./dist/antd.compact.min.css 66.7 kB +78 B (0%)
./dist/antd.dark.min.css 68 kB +79 B (0%)
./dist/antd.min.css 66.7 kB +69 B (0%)
./dist/antd.min.js 275 kB +10 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bef20f:

Sandbox Source
antd reproduction template Configuration
Standalone - [email protected] Issue #28231

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #28240 (2bef20f) into master (237ab9a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7388      7389    +1     
  Branches      2119      2119           
=========================================
+ Hits          7388      7389    +1     
Impacted Files Coverage Δ
components/badge/ScrollNumber.tsx 100.00% <100.00%> (ø)
components/badge/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237ab9a...2bef20f. Read the comment docs.

@zombieJ zombieJ merged commit 600fc0a into master Dec 7, 2020
@zombieJ zombieJ deleted the fix-badge branch December 7, 2020 13:23
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
* fix: badge motion style

* chore: Clean up related code

* test: Update test case
vouis pushed a commit to vouis/ant-design that referenced this pull request Dec 10, 2020
* fix: badge motion style

* chore: Clean up related code

* test: Update test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone badge jumps after getting initial value from top right to its position
2 participants