Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select ref typescript typo #27482

Merged
merged 2 commits into from
Nov 3, 2020
Merged

fix: select ref typescript typo #27482

merged 2 commits into from
Nov 3, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Oct 30, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27474

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Select ref props typescript typo.
🇨🇳 Chinese 修复Select ref 属性 typescript 错误。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 30, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2020

Size Change: -1.12 kB (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB -599 B (0%)
./dist/antd.compact.min.css 66.5 kB +18 B (0%)
./dist/antd.dark.min.css 67.8 kB +27 B (0%)
./dist/antd.min.css 66.5 kB +23 B (0%)
./dist/antd.min.js 277 kB -585 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31b32b2:

Sandbox Source
antd reproduction template Configuration
quizzical-curie-db4i3 Issue #27474

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #27482 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7404      7385   -19     
  Branches      2087      2076   -11     
=========================================
- Hits          7404      7385   -19     
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <ø> (ø)
components/auto-complete/index.tsx 100.00% <100.00%> (ø)
components/grid/col.tsx 100.00% <0.00%> (ø)
components/grid/row.tsx 100.00% <0.00%> (ø)
components/form/Form.tsx 100.00% <0.00%> (ø)
components/modal/Modal.tsx 100.00% <0.00%> (ø)
components/steps/index.tsx 100.00% <0.00%> (ø)
components/avatar/group.tsx 100.00% <0.00%> (ø)
components/avatar/avatar.tsx 100.00% <0.00%> (ø)
components/modal/confirm.tsx 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84726ae...31b32b2. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Nov 2, 2020

为啥是 HTMLInputElement,它 Ref 的就是 Select 呀。 。 。

@zombieJ
Copy link
Member

zombieJ commented Nov 2, 2020

看起来直接定义一个 focus 和 blur 应该就可以了:https://github.com/react-component/select/blob/7ca11a86d61b6b3db493a82bb08cd53ed138dd4d/src/Select.tsx#L73

@afc163 afc163 mentioned this pull request Nov 2, 2020
@hengkx
Copy link
Member Author

hengkx commented Nov 2, 2020

@zombieJ
Copy link
Member

zombieJ commented Nov 2, 2020

对,只要这两个。之前是 class,现在不需要剩余那些东东了。

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 3, 2020

/rebase

@zombieJ zombieJ merged commit 8faccc2 into master Nov 3, 2020
@zombieJ zombieJ deleted the fix-27474 branch November 3, 2020 03:09
headwindz pushed a commit to headwindz/ant-design that referenced this pull request Nov 4, 2020
* fix: select ref typescript typo

* improve
@afc163 afc163 mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to type SelectRef after upgrading to 4.7
5 participants