Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form warning #27343

Merged
merged 2 commits into from
Oct 24, 2020
Merged

fix: Form warning #27343

merged 2 commits into from
Oct 24, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #27321

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form warning for non-boolean attribute virtual when use ConfigProvider.
🇨🇳 Chinese 修复 Form 在 ConfigProvider 下会警告 non-boolean attribute 'virtual' 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 24, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5cda6e3:

Sandbox Source
antd reproduction template Configuration
wispy-sun-x9u7j Issue #27321

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #27343 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7389      7392    +3     
  Branches      2025      2074   +49     
=========================================
+ Hits          7389      7392    +3     
Impacted Files Coverage Δ
components/config-provider/context.tsx 100.00% <ø> (ø)
components/drawer/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b25b4...5cda6e3. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -167 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB -68 B (0%)
./dist/antd.min.js 277 kB -99 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@zombieJ zombieJ merged commit d6bd89e into master Oct 24, 2020
@zombieJ zombieJ deleted the fix-warning branch October 24, 2020 06:47
@zombieJ zombieJ mentioned this pull request Oct 24, 2020
15 tasks
07akioni pushed a commit that referenced this pull request Nov 7, 2020
* fix: Not warning in drawer

* add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider 设置 virtual 时 Drawer 抛出异常警告
2 participants