Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table empty filters throw warning #26001

Merged
merged 1 commit into from
Aug 4, 2020
Merged

fix: Table empty filters throw warning #26001

merged 1 commit into from
Aug 4, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 4, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25979

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table empty filters throw warning.
🇨🇳 Chinese 修复 Table 空筛选项在控制台抛出 warning 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/head.md

@afc163 afc163 force-pushed the fix-table-warning branch from 01b9cf3 to 7b1071c Compare August 4, 2020 03:17
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 4, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 4, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b1071c:

Sandbox Source
antd reproduction template Configuration
naughty-bartik-4kkhj Issue #25979

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

Size Change: +5 B (0%)

Total Size: 785 kB

Filename Size Change
./dist/antd-with-locales.min.js 311 kB +3 B (0%)
./dist/antd.min.js 279 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 64.7 kB 0 B
./dist/antd.dark.min.css 66 kB 0 B
./dist/antd.min.css 64.7 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #26001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26001   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7314     7314           
  Branches     2042     1994   -48     
=======================================
  Hits         7283     7283           
  Misses         31       31           
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4418d0...7b1071c. Read the comment docs.

@afc163 afc163 merged commit 8d7cbbd into master Aug 4, 2020
@afc163 afc163 deleted the fix-table-warning branch August 4, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table 组件用到筛选的时候,当filters参数值为[]空数组的时候,报一大堆警告
3 participants